Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency loop with statustracker and markdown #8821

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Jul 17, 2024

There's a dependency loop introduced by #8817 where statustracker imports markdown which imports statustracker.

This PR implements #8817 without using markdown.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 17, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/eea2a14eae7f60b7f2865f24daa87ccd6382d9cf/gradio-4.38.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@eea2a14eae7f60b7f2865f24daa87ccd6382d9cf#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/eea2a14eae7f60b7f2865f24daa87ccd6382d9cf/gradio-client-1.3.0.tgz

@aliabd aliabd requested a review from abidlabs July 17, 2024 18:28
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jul 17, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/statustracker patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix dependency loop with statustracker and markdown

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Jul 17, 2024
Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @aliabd!

Confirmed that sanitization is working correctly, e.g. with:

import gradio as gr
import time

def show():
    gr.Info("Please visit <p>abc<iframe//src=jAva&Tab;script:alert(3)>def</p> for free datasets.", duration=100)
    time.sleep(1)
    return "Hello"


gr.Interface(show, None, "textbox").launch()

@abidlabs abidlabs enabled auto-merge (squash) July 17, 2024 18:37
@abidlabs abidlabs merged commit cea3bf9 into main Jul 17, 2024
7 of 8 checks passed
@abidlabs abidlabs deleted the aliabd/fix-recursive-import branch July 17, 2024 18:55
This was referenced Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants