-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependency loop with statustracker and markdown #8821
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/eea2a14eae7f60b7f2865f24daa87ccd6382d9cf/gradio-4.38.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@eea2a14eae7f60b7f2865f24daa87ccd6382d9cf#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-builds.s3.amazonaws.com/eea2a14eae7f60b7f2865f24daa87ccd6382d9cf/gradio-client-1.3.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @aliabd!
Confirmed that sanitization is working correctly, e.g. with:
import gradio as gr
import time
def show():
gr.Info("Please visit <p>abc<iframe//src=jAva	script:alert(3)>def</p> for free datasets.", duration=100)
time.sleep(1)
return "Hello"
gr.Interface(show, None, "textbox").launch()
There's a dependency loop introduced by #8817 where statustracker imports markdown which imports statustracker.
This PR implements #8817 without using markdown.