Add client wheel url to main spaces #7612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/1302e41bf442c9ddfd20412349cf972931d17806/gradio-4.19.2-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@1302e41bf442c9ddfd20412349cf972931d17806#subdirectory=client/python" |
🦄 no changes detectedThis Pull Request does not include changes to any packages.__No changes detected. __
|
abidlabs
reviewed
Mar 5, 2024
| if args.AUTH_TOKEN is not None: | ||
| hello_world_version = str(huggingface_hub.space_info("gradio/hello_world").cardData["sdk_version"]) | ||
| for demo in demos: | ||
| if hello_world_version != args.GRADIO_VERSION: | ||
| upload_demo_to_space(demo_name=demo, space_id="gradio/" + demo, hf_token=args.AUTH_TOKEN, gradio_version=args.GRADIO_VERSION) | ||
| upload_demo_to_space(demo_name=demo, space_id="gradio/" + demo + "_main", hf_token=args.AUTH_TOKEN, gradio_version=args.GRADIO_VERSION, gradio_wheel_url=gradio_wheel_url) | ||
| upload_demo_to_space(demo_name=demo, space_id="gradio/" + demo + "_main", hf_token=args.AUTH_TOKEN, gradio_version=args.GRADIO_VERSION, gradio_wheel_url=gradio_wheel_url, gradio_client_url=args.CLIENT_URL) |
There was a problem hiding this comment.
We modify args.WHEEL_URL by adding "gradio-{args.GRADIO_VERSION}-py3-none-any.whl" to it. Do we need to do the same thing for the gradio_client?
There was a problem hiding this comment.
Nope, the gradio_client is just installed from github, so there's no actual wheel file. it's just something like
gradio-client @ git+https://github.com/gradio-app/gradio@c0d25fc1df60987793471b4745ab453bea92dcfe#subdirectory=client/python
that's also what we do for the pr demos
There was a problem hiding this comment.
Ok great! Thanks for clarifying
|
Just one question above^ @aliabd but otherwise lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing client wheel url to the requirements for main website spaces.