Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing local var #8

Closed
ncannasse opened this issue Jul 3, 2013 · 2 comments
Closed

Missing local var #8

ncannasse opened this issue Jul 3, 2013 · 2 comments
Assignees
@gorhill

Comments

@ncannasse
Copy link

While porting the code to Haxe, I noticed that you're missing a local "var v" in getBbox loop.
@ncannasse
Copy link
Author

Actually "vx" and "vy" too

@ncannasse
Copy link
Author

Another one in "pointIntersection" (halfedge)

@ghost ghost assigned gorhill Sep 20, 2013
gorhill added a commit that referenced this issue Sep 22, 2013
@gorhill
added missing var as per #8
6c117b9
gorhill added a commit that referenced this issue Sep 22, 2013
@gorhill
issue #8
a08efc1
@gorhill gorhill closed this as completed Sep 22, 2013
gorhill referenced this issue in mbostock/Javascript-Voronoi Sep 22, 2013
@mbostock
Fix initial duplicate detection.
1ab5fb9 
When detecting coincident points, the previous site [xsitex, xsitey] should be
initialized to an illegal value (different from any potential valid input site).
But [Number.MIN_VALUE, Number.MIN_VALUE] is a valid site, so use [undefined,
undefined] instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gorhill gorhill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gorhill @ncannasse