Disable WI in create-gke-cluster step #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a known GKE issue that we can tie this to? That way, we can create an issue to renable this - and make that issue depending on the root cause issue? |
|
issuetracker.google.com/issues/143944398 is related to this. I'm not sure if there is any other internal issues though. |
|
Create an issue to enable WI adding the link to the issue - so we remember to fix it. |
sawagh
approved these changes
Nov 7, 2019
yfei1
added a commit
to yfei1/open-match
that referenced
this pull request
Nov 14, 2019
yfei1
pushed a commit
that referenced
this pull request
Nov 14, 2019
* Enabled telemetry when generating assets (#945) * Optimize developer workflow (#943) * Remove k8s probes in example mmfs and evaluator (#942) * Update release template (#944) * Fix scale test based on the config changes (#948) * Update go.mod dendencies (#949) * Disable Redis initContainer by default (#941) * Bumped helm version and dependencies versions for k8s 1.16 support (#938) * Disable WI in create-gke-cluster step (#947) * Turn off subcharts by default (#954) * Split out MMF and Evaluator install from open-match-demo (#956) * Move Match Function installation to the matchmaker.yaml - since customization.yaml is now optional when using default evaluator installation steps (#957) * Define Makefile and RBAC rules for open-match-demo namespace migration (#958) * Have MMF and Evaluator in customize chart use different configs (#959) * Fix namespace dependency on CI (#967) * Update tutorial modules to use v0.8 rc (#963) * A Tutorial to customize the evaluator (#970) * Publish helm index.yaml file to helm install open-match (#962) * Generate static yaml to install open match demo (#969) * Generate static yaml to install open match demo * Update Makefile to sync with the latest demo update * Add a tutorial for using the default evaluator (#961) * Add the solution for Matchmaker 101 tutorial to a separate solution folder. (#971) * Add logging to the default evaluator (#964) * Add solution folder to Matchmaker 102 tutorial (#973) * Ignore reaper error (#974) * Harden the open-match parent chart (#972) * Fix typo in folder name (#975) * More cleanup (#976) * Remove redundant matchmaker scaffold and update tutorials (#979) * Update release numbers to 0.8, and presubmit's formatting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #946. Temporarily disable WI until GKE team fixes it.