Fix a race where assigned tickets still get returned by Query Tickets #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnored ticket could be returned as they move out of ignore list upon assignment
yfei1
approved these changes
Oct 30, 2019
|
@googlebot rescan |
yfei1
pushed a commit
to yfei1/open-match
that referenced
this pull request
Nov 1, 2019
…gnored ticket could be returned as they move out of ignore list upon assignment (googleforgames#918)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in query tickets, we fetch tickets from redis and then check the ignore list. When a ticket is assigned, it gets removed from index and then from index list. Here is a race:
Request1: Sets assignment received for Ticket A.
Requset2: Query Tickets call received
Fix here is to fetch ignore list BEFORE fetching the index. In the worst case, A will be in ignore list and not in index - which is OK since we only consider tickets from index.