Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auto-approve): update PythonSampleDependency for python team #5266

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Nov 21, 2023

See "[Implementation] Auto-approve Python docs samples"

After discussion, will fix #5241 per conversation

cc @msampathkumar

@sofisl sofisl requested a review from a team as a code owner November 21, 2023 08:00
@sofisl sofisl changed the title fix: update PythonSampleDependency for python team fix[auto-approve]: update PythonSampleDependency for python team Nov 21, 2023
@sofisl sofisl changed the title fix[auto-approve]: update PythonSampleDependency for python team fix(auto-approve): update PythonSampleDependency for python team Nov 21, 2023
@sofisl
Copy link
Contributor Author

sofisl commented Dec 5, 2023

Thank you for the review @SurferJeffAtGoogle! @msampathkumar, will you review as well, and confirm everything conforms to what we discussed?

@sofisl sofisl assigned msampathkumar and unassigned chingor13 Dec 5, 2023
@sofisl sofisl added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 5, 2023
@sofisl sofisl merged commit 7d8c2fe into main Dec 6, 2023
23 checks passed
@sofisl sofisl deleted the addPythonSampleDep branch December 6, 2023 15:18
@msampathkumar
Copy link

Thank you for your work @sofisl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query request(auto-approve): Request for available/possible customisation to use auto-approve bot
4 participants