Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitHub CI Action for GTFS-RT .proto validation #232

Merged
merged 6 commits into from
Jul 10, 2020

Conversation

barbeau
Copy link
Collaborator

@barbeau barbeau commented Jul 8, 2020

This PR adds continuous integration validation for the gtfs-realtime.proto file that will run on any new proposals on this GitHub repository. It uses the official Protocol Buffer protoc compiler and generates the Java bindings as a test. This will help catch syntax errors in the GTFS-realtime gtfs-realtime.proto file prior to merging.

Example of a failing build due to missing a { in a test gtfs-realtime.proto file:
https://github.com/MobilityData/transit/runs/850298249

Example of a passing build (using the .proto currently in the master branch):
https://github.com/MobilityData/transit/runs/850308445

@barbeau barbeau added the GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime label Jul 8, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@barbeau barbeau merged commit 422b461 into google:master Jul 10, 2020
@barbeau barbeau deleted the ci-proto branch July 10, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS Realtime Issues and Pull Requests that focus on GTFS Realtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants