This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Make java version android-friendly #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace gson with org.json.JSONObject api. Note that android includes org.json in the framework, so if deploying keyczar to android don't bundle the org.json lib. - Remove all java logging. Previously, errors during JSON parsing threw unchecked gson exceptions. Now we throw RuntimeExceptions wrapping checked JSONException.
- Replace gson with org.json.JSONObject api. Note that android includes org.json in the framework, so if deploying keyczar to android don't bundle the org.json lib. - Remove all java logging. Previously, errors during JSON parsing threw unchecked gson exceptions. Now we throw RuntimeExceptions wrapping checked JSONException.
divegeek
added a commit
that referenced
this pull request
Apr 14, 2015
Make java version android-friendly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests still pass. :-)
Note: previously, errors during JSON parsing threw unchecked gson exceptions. Now we throw RuntimeExceptions wrapping checked JSONException.
I don't know how to test Eclipse/Maven project integration.