feat: Implement organization role assignments for both users and teams #3281
+204
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While working on this I noticed that the file naming is slightly off from how GitHub structures their API:s. There's a difference between repository roles and organization roles, but currently the Leaving it up to the reviewer to decide if this should be done in this PR directly or in a separate one later |
gmlewis
changed the title
Please perform the reorganization in your next PR. Thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3281 +/- ##
==========================================
- Coverage 97.72% 92.96% -4.76%
==========================================
Files 153 171 +18
Lines 13390 11705 -1685
==========================================
- Hits 13085 10882 -2203
- Misses 215 729 +514
- Partials 90 94 +4 ☔ View full report in Codecov by Sentry. |
gmlewis
requested changes
Sep 21, 2024
| // GitHub API docs: https://docs.github.com/rest/orgs/organization-roles#assign-an-organization-role-to-a-team | ||
| // | ||
| //meta:operation PUT /orgs/{org}/organization-roles/teams/{team_slug}/{role_id} | ||
| func (s *OrganizationsService) AssignOrgRoleToTeam(ctx context.Context, org string, teamSlug string, roleID int64) (*Response, error) { |
There was a problem hiding this comment.
Suggested change
| func (s *OrganizationsService) AssignOrgRoleToTeam(ctx context.Context, org string, teamSlug string, roleID int64) (*Response, error) { | |
| func (s *OrganizationsService) AssignOrgRoleToTeam(ctx context.Context, org, teamSlug string, roleID int64) (*Response, error) { |
| // GitHub API docs: https://docs.github.com/rest/orgs/organization-roles#remove-an-organization-role-from-a-team | ||
| // | ||
| //meta:operation DELETE /orgs/{org}/organization-roles/teams/{team_slug}/{role_id} | ||
| func (s *OrganizationsService) RemoveOrgRoleFromTeam(ctx context.Context, org string, teamSlug string, roleID int64) (*Response, error) { |
There was a problem hiding this comment.
Suggested change
| func (s *OrganizationsService) RemoveOrgRoleFromTeam(ctx context.Context, org string, teamSlug string, roleID int64) (*Response, error) { | |
| func (s *OrganizationsService) RemoveOrgRoleFromTeam(ctx context.Context, org, teamSlug string, roleID int64) (*Response, error) { |
| // GitHub API docs: https://docs.github.com/rest/orgs/organization-roles#assign-an-organization-role-to-a-user | ||
| // | ||
| //meta:operation PUT /orgs/{org}/organization-roles/users/{username}/{role_id} | ||
| func (s *OrganizationsService) AssignOrgRoleToUser(ctx context.Context, org string, username string, roleID int64) (*Response, error) { |
There was a problem hiding this comment.
Suggested change
| func (s *OrganizationsService) AssignOrgRoleToUser(ctx context.Context, org string, username string, roleID int64) (*Response, error) { | |
| func (s *OrganizationsService) AssignOrgRoleToUser(ctx context.Context, org, username string, roleID int64) (*Response, error) { |
| return resp, nil | ||
| } | ||
|
|
||
| // RemoveOrgRoleFromUser removes an existing organization role assignment to a user in this organization. |
There was a problem hiding this comment.
Suggested change
| // RemoveOrgRoleFromUser removes an existing organization role assignment to a user in this organization. | |
| // RemoveOrgRoleFromUser removes an existing organization role assignment from a user in this organization. |
| return resp, nil | ||
| } | ||
|
|
||
| // RemoveOrgRoleFromTeam removes an existing organization role assignment to a team in this organization. |
There was a problem hiding this comment.
Suggested change
| // RemoveOrgRoleFromTeam removes an existing organization role assignment to a team in this organization. | |
| // RemoveOrgRoleFromTeam removes an existing organization role assignment from a team in this organization. |
| // GitHub API docs: https://docs.github.com/rest/orgs/organization-roles#remove-an-organization-role-from-a-user | ||
| // | ||
| //meta:operation DELETE /orgs/{org}/organization-roles/users/{username}/{role_id} | ||
| func (s *OrganizationsService) RemoveOrgRoleFromUser(ctx context.Context, org string, username string, roleID int64) (*Response, error) { |
There was a problem hiding this comment.
Suggested change
| func (s *OrganizationsService) RemoveOrgRoleFromUser(ctx context.Context, org string, username string, roleID int64) (*Response, error) { | |
| func (s *OrganizationsService) RemoveOrgRoleFromUser(ctx context.Context, org, username string, roleID int64) (*Response, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3280