[Kotlin] Support for optional scalars. #6115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulovap
force-pushed
the
kotlin_scalar_optional
branch
2 times, most recently
from
491582f
to
ed71f40
Compare
vglavnyy
reviewed
Sep 14, 2020
More information on google#6014
paulovap
force-pushed
the
kotlin_scalar_optional
branch
from
ed71f40
to
d1ee5e1
Compare
|
LGTM! |
|
@CasperN ? |
CasperN
reviewed
Sep 14, 2020
| auto base_type = field.value.type.base_type; | ||
|
|
||
| auto r_type = GenTypeGet(field.value.type); | ||
| if (field.IsScalarOptional() || |
There was a problem hiding this comment.
Do you not need to check for required fields?
I'm hoping field.optional is enough to determine whether the output field is optional or not - (though we're already inconsistent around vectors as nonpresense is null in C++/Rust but empty-vector in swift)
There was a problem hiding this comment.
Do you not need to check for required fields?
Scalar fields can't have required attribute.
@aardappel Merge it?
Merged
ivannp
pushed a commit
to ivannp/flatbuffers
that referenced
this pull request
Oct 2, 2020
More information on google#6014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More information on #6014