Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists: Fix handling of go arrays #894

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

alvaroaleman
Copy link
Contributor

Go arrays currently cause a panic, because reflect.MakeSlice is used to construct them which is invalid, this change fixes that.

Pull Requests Guidelines

See CONTRIBUTING.md for more details about when to create
a GitHub Pull Request and when other kinds of contributions or
consultation might be more desirable.

When creating a new pull request, please fork the repo and work within a
development branch.

Commit Messages

  • Most changes should be accompanied by tests.
  • Commit messages should explain why the changes were made.
Summary of change in 50 characters or less

Background on why the change is being made with additional detail on
consequences of the changes elsewhere in the code or to the general
functionality of the library. Multiple paragraphs may be used, but
please keep lines to 72 characters or less.

Reviews

  • Perform a self-review.
  • Make sure the Travis CI build passes.
  • Assign a reviewer once both the above have been completed.

Merging

  • If a CEL maintaner approves the change, it may be merged by the author if
    they have write access. Otherwise, the change will be merged by a maintainer.
  • Multiple commits should be squashed before merging.
  • Please append the line closes #<issue-num>: description in the merge message,
    if applicable.

TristonianJones
TristonianJones previously approved these changes Feb 1, 2024
@TristonianJones
Copy link
Collaborator

/gcbrun

Go arrays currently cause a panic, because `reflect.MakeSlice` is used
to construct them which is invalid, this change fixes that.
@alvaroaleman
Copy link
Contributor Author

Had to rebase to fix some conflicts, please take another look when you can.

@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones TristonianJones merged commit f221e70 into google:master Feb 2, 2024
2 checks passed
@alvaroaleman alvaroaleman deleted the fix-arrays branch February 3, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants