-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwiftUI sample app #63
Conversation
d638465
to
6b42b34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branding
Let's come up with a fun app name to replace GSI-Swift-Sample. We were kicking around a few of these already... BirthdayParty, BirthdayCountdown, BirthdayCheck?
Packaging
We'll want to demonstrate CocoaPods as well as SPM dependency management. We could add a CocoaPods specific project and Podfile for the new app as we've done for the existing sample.
Directory Structure
Consider the following layout...
Samples/Objc/SignInSample/.xcodeproj
Samples/Swift/SAMPLE_APP_NAME/.xcodeproj
Might be nice to avoid having a duplicate level inside SAMPLE_APP_NAME/ as with the current GSI-Swift-Sample/GSI-Swift-Sample/
Samples/Swift/GSI-Swift-Sample/GSI-Swift-Sample.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
1dde75f
to
0f84a64
Compare
ece2d6a
to
5e6695d
Compare
98db3bc
to
75a120d
Compare
75a120d
to
9ecb6f5
Compare
This pull request adds a sample app demonstrating the use of GoogleSignIn-iOS in SwiftUI.