-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the weekly meeting more prominent in the README #881
Conversation
Codecov Report
@@ Coverage Diff @@
## master #881 +/- ##
=======================================
Coverage 60.73% 60.73%
=======================================
Files 74 74
Lines 2325 2325
=======================================
Hits 1412 1412
Misses 787 787
Partials 126 126 Continue to review full report at Codecov.
|
Taking some design tips from the Harbor project, lets use something similar on Athens. === Alter text slightly to read better I feel that this text reads slightly better than before === Don't use the participating section... Due to a mistake, I used the participating page rather than the developer meeting page Signed-off-by: Chris M <millscj01@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, missing new line in the svg but that's not huge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chriscoffee looks awesome, thank you. I am going to open up a follow-on PR to move the banner up and make the project banner smaller
@arschles Thanks, I would have been happy to do that in this PR y'know |
Taking some design tips from the Harbor project, lets use something similar on Athens. === Alter text slightly to read better I feel that this text reads slightly better than before === Don't use the participating section... Due to a mistake, I used the participating page rather than the developer meeting page Signed-off-by: Chris M <millscj01@gmail.com>
What is the problem I am trying to address?
It's not really that clear that we have developer meetings every week. It'd be cool if
How is the fix applied?
Just a simple table with an icon. It's a nice to have.
Suggestions welcomed for placement of said table and any content changes.
Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
Fixes #875