Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the weekly meeting more prominent in the README #881

Merged
merged 4 commits into from
Nov 9, 2018
Merged

Make the weekly meeting more prominent in the README #881

merged 4 commits into from
Nov 9, 2018

Conversation

chriscoffee
Copy link
Member

What is the problem I am trying to address?

It's not really that clear that we have developer meetings every week. It'd be cool if

Info on our weekly dev meetings could be more prominent.

How is the fix applied?

Just a simple table with an icon. It's a nice to have.

Suggestions welcomed for placement of said table and any content changes.

Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.

Fixes #875

@chriscoffee chriscoffee requested a review from a team as a code owner November 8, 2018 14:49
@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #881 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #881   +/-   ##
=======================================
  Coverage   60.73%   60.73%           
=======================================
  Files          74       74           
  Lines        2325     2325           
=======================================
  Hits         1412     1412           
  Misses        787      787           
  Partials      126      126

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f524d2...97e5d7e. Read the comment docs.

README.md Outdated Show resolved Hide resolved
Christopher Mills and others added 3 commits November 8, 2018 15:25
Taking some design tips from the Harbor project, lets use something
similar on Athens.

===

Alter text slightly to read better

I feel that this text reads slightly better than before

===

Don't use the participating section...

Due to a mistake, I used the participating page rather than the
developer meeting page

Signed-off-by: Chris M <millscj01@gmail.com>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, missing new line in the svg but that's not huge.

Copy link
Member

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet
image

Copy link
Member

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chriscoffee looks awesome, thank you. I am going to open up a follow-on PR to move the banner up and make the project banner smaller

@arschles arschles merged commit a442917 into gomods:master Nov 9, 2018
@chriscoffee
Copy link
Member Author

@arschles Thanks, I would have been happy to do that in this PR y'know

@chriscoffee chriscoffee deleted the 875 branch November 11, 2018 12:54
arschles pushed a commit to arschles/athens that referenced this pull request Feb 22, 2019
Taking some design tips from the Harbor project, lets use something
similar on Athens.

===

Alter text slightly to read better

I feel that this text reads slightly better than before

===

Don't use the participating section...

Due to a mistake, I used the participating page rather than the
developer meeting page

Signed-off-by: Chris M <millscj01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put a prominent notice in our readme about the weekly meeting
6 participants