chore: remove last drone remains #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-ashish
reviewed
Feb 28, 2023
| @@ -48,7 +48,7 @@ func (s *Storage) clear() error { | |||
|
|
|||
| func getStorage(t testing.TB) *Storage { | |||
| t.Helper() | |||
| bucketName := randomBucketName(os.Getenv("DRONE_PULL_REQUEST")) | |||
| bucketName := randomBucketName(os.Getenv("GA_PULL_REQUEST")) | |||
There was a problem hiding this comment.
My guess is that, should there be a bug, you can actually find the bucket. Otherwise it is always random, and you can never find it.
r-ashish
reviewed
Feb 28, 2023
r-ashish
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
This PR removes the last references to Drone.
How is the fix applied?
athens_drone_stash_bucketwas left as this is a bucket name, and it is unclear if changing it will break things.What GitHub issue(s) does this PR fix or close?
Fixes #1833