Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rabbitmq): return consumerTag when creating subscriber #769

Merged

Conversation

gunesyu
Copy link
Contributor

@gunesyu gunesyu commented Aug 16, 2024

fix #755

@underfisk
Copy link
Contributor

@gunesyu May we have tests to reflect this bugfix?

@gunesyu
Copy link
Contributor Author

gunesyu commented Aug 17, 2024

@gunesyu May we have tests to reflect this bugfix?

thanks @underfisk , updated with a new commit includes tests for both createSubscriber and createRpc

@underfisk underfisk enabled auto-merge (squash) August 18, 2024 13:56
auto-merge was automatically disabled August 20, 2024 21:24

Head branch was pushed to by a user without write access

@gunesyu gunesyu force-pushed the fix/755-rabbitmq-return-consumertag branch from b529dd2 to 01c18b3 Compare August 20, 2024 21:24
@gunesyu
Copy link
Contributor Author

gunesyu commented Aug 20, 2024

@underfisk needed a rebase to update the branch

@underfisk underfisk merged commit 5137c0f into golevelup:master Aug 21, 2024
3 checks passed
@lzw1926
Copy link

lzw1926 commented Aug 26, 2024

@underfisk Looking forward the new release contain this PR ASAP, which seems to fixed a bug I encountered when I use the following configuration. The custom direct exchange won't be setup correctly and the relevant channel throw errors.

And when I introduce the local build package with the current master code to my project, everything works just fine !

exchanges: [
  {
    name: DIRECT_EXCHANGE,
    type: 'direct',
  },
],
connectionInitOptions: {
  wait: false,
},

@underfisk
Copy link
Contributor

@underfisk Looking forward the new release contain this PR ASAP, which seems to fixed a bug I encountered when I use the following configuration. The custom direct exchange won't be setup correctly and the relevant channel throw errors.

And when I introduce the local build package with the current master code to my project, everything works just fine !

exchanges: [
  {
    name: DIRECT_EXCHANGE,
    type: 'direct',
  },
],
connectionInitOptions: {
  wait: false,
},

The releases are handled by @WonderPanda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RabbitMQ - returning consumerTag when creating subscribers
3 participants