Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Action for code quality and unit test using rspec #1

Merged
merged 12 commits into from
Sep 7, 2021

Conversation

r0r1
Copy link
Contributor

@r0r1 r0r1 commented Aug 22, 2021

  • Add Rubocop and RubyCritic for Code Quality
  • Run Rspec for unit test
  • Set code coverage minimum to 73%

@r0r1 r0r1 changed the title [WIP] - Add Github Action for code quality and unit test using rspec Add Github Action for code quality and unit test using rspec Aug 22, 2021
@r0r1 r0r1 requested a review from rafeequl August 26, 2021 10:03
@barockok
Copy link
Collaborator

barockok commented Sep 3, 2021

please resolve the conflict.

@r0r1
Copy link
Contributor Author

r0r1 commented Sep 6, 2021

please resolve the conflict.

done

@r0r1 r0r1 closed this Sep 6, 2021
@r0r1 r0r1 reopened this Sep 6, 2021
@barockok barockok merged commit 353e733 into development Sep 7, 2021
r0r1 pushed a commit that referenced this pull request Oct 11, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 11, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 11, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 11, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 11, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 13, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 13, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 13, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 13, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 15, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 15, 2021
Add Github Action for code quality and unit test using rspec
r0r1 pushed a commit that referenced this pull request Oct 15, 2021
Add Github Action for code quality and unit test using rspec
barockok pushed a commit that referenced this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants