Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log4j-web jar to core and serving #498

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

Yanson
Copy link
Contributor

@Yanson Yanson commented Feb 26, 2020

What this PR does / why we need it:

When starting serving or core (with info level logs) the following warning shows up:

2020-02-26 17:38:47,600 restartedMain INFO Log4j appears to be running in a Servlet environment, but there's no log4j-web module available. If you want better web container support, please add the log4j-web JAR to your web archive or server lib directory.

This PR adds the log4j-web jar as requested by this message. I don't believe there are any other implications, it is just to omit the warning.

Given the jar is ~30K I think this is harmless.

Which issue(s) this PR fixes:

n/a

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @Yanson. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Yanson
Copy link
Contributor Author

Yanson commented Feb 26, 2020

/assign @thirteen37

@woop
Copy link
Member

woop commented Feb 27, 2020

/ok-to-test

@woop
Copy link
Member

woop commented Feb 27, 2020

/lgtm

@woop
Copy link
Member

woop commented Feb 27, 2020

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop, Yanson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 9e4b4f6 into feast-dev:master Feb 27, 2020
@Yanson Yanson deleted the log4j-web branch February 27, 2020 12:03
khorshuheng pushed a commit to khorshuheng/feast that referenced this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants