fix: error log use wrong variable err #18602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MoonStrider <37744291+dyf991645@users.noreply.github.com>
MinerYang
approved these changes
Apr 26, 2023
Codecov Report
@@ Coverage Diff @@
## main #18602 +/- ##
==========================================
+ Coverage 67.38% 67.41% +0.02%
==========================================
Files 984 984
Lines 107010 107010
Branches 2670 2670
==========================================
+ Hits 72113 72139 +26
+ Misses 31014 30992 -22
+ Partials 3883 3879 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
OrlinVasilev
approved these changes
Apr 26, 2023
|
@dyf991645 congrats on your first PR here :) |
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
Update manager.go Signed-off-by: MoonStrider <37744291+dyf991645@users.noreply.github.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
At harbor/src/jobservice/mgt/manager.go(161). logger.Errorf should log the er variable returned by t.Load(), which is assigned to the
ervariable. However, the err variable is referenced instead.