Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redis password using safe special characters #18566

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Allow redis password using safe special characters #18566

merged 1 commit into from
Apr 24, 2023

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Apr 20, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes ##18538

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Apr 20, 2023
@MinerYang MinerYang requested a review from a team as a code owner April 20, 2023 06:19
@MinerYang MinerYang assigned stonezdj and chlins and unassigned wy65701436, zyyw and chlins Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #18566 (a9c2b0c) into main (8229134) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18566      +/-   ##
==========================================
- Coverage   67.39%   67.38%   -0.02%     
==========================================
  Files         984      984              
  Lines      107010   107010              
  Branches     2670     2670              
==========================================
- Hits        72121    72110      -11     
- Misses      31010    31019       +9     
- Partials     3879     3881       +2     
Flag Coverage Δ
unittests 67.38% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
Copy link
Member

chlins commented Apr 23, 2023

@MinerYang Is harbor-helm affected by this issue?

@MinerYang
Copy link
Contributor Author

@MinerYang Is harbor-helm affected by this issue?

This would only cover the offline installer case

Signed-off-by: yminer <yminer@vmware.com>

string and None type conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants