Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add goheader linter settings #18503

Merged
merged 1 commit into from
Apr 25, 2023
Merged

add goheader linter settings #18503

merged 1 commit into from
Apr 25, 2023

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang added the release-note/update Update or Fix label Apr 10, 2023
@MinerYang MinerYang requested a review from a team as a code owner April 10, 2023 02:15
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #18503 (096ec11) into main (2d98e8f) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18503      +/-   ##
==========================================
- Coverage   67.39%   67.36%   -0.03%     
==========================================
  Files         984      984              
  Lines      107010   107010              
  Branches     2670     2670              
==========================================
- Hits        72116    72084      -32     
- Misses      31017    31053      +36     
+ Partials     3877     3873       -4     
Flag Coverage Δ
unittests 67.36% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/common/dao/testutils.go 31.68% <ø> (ø)
src/common/dao/utils.go 100.00% <ø> (ø)
src/common/job/client.go 39.77% <ø> (ø)
src/common/models/oidc_user.go 100.00% <ø> (ø)
src/common/rbac/system/evaluator.go 0.00% <ø> (ø)
src/common/rbac/system/namespace.go 47.05% <ø> (ø)
src/common/security/v2token/context.go 56.94% <ø> (ø)
src/common/utils/passports.go 90.19% <ø> (ø)
src/controller/artifact/annotation/parser.go 85.00% <ø> (ø)
src/controller/artifact/annotation/v1alpha1.go 64.81% <ø> (ø)
... and 245 more

... and 28 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang assigned chlins and unassigned zyyw and AllForNothing Apr 24, 2023
fix files for goheader linter

fix copyright 2018/2019

Signed-off-by: yminer <yminer@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit ebac530 into goharbor:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants