Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Golint & FGT installation commands in Project Setup Documentation #18282

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fixed Golint & FGT installation commands in Project Setup Documentation #18282

merged 1 commit into from
Apr 24, 2023

Conversation

yrs147
Copy link
Contributor

@yrs147 yrs147 commented Feb 27, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

The installation commands for Golint and FGT given in CONRTIBUTING.md were not working and were showing the following
Errors.

go: go.mod file not found in current directory or any parent directory.
        'go get' is no longer supported outside a module.
        To build and install a command, use 'go install' with a version,
        like 'go install example.com/cmd@latest'
        For more information, see https://golang.org/doc/go-get-install-deprecation
        or run 'go help get' or 'go help install'.
go: go.mod file not found in current directory or any parent directory.
        'go get' is no longer supported outside a module.
        To build and install a command, use 'go install' with a version,
        like 'go install example.com/cmd@latest'
        For more information, see https://golang.org/doc/go-get-install-deprecation
        or run 'go help get' or 'go help install'.

Solution: Changed the commands in the documentation of CONTRIBUTING.md that fixes this issue.

Before

go get -u golang.org/x/lint/golint
go get github.com/GeertJohan/fgt 

Changes Proposed

go install golang.org/x/lint/golint@latest
go install github.com/GeertJohan/fgt@latest

Issue being fixed

Fixes https://cloud-native.slack.com/archives/CC1E0J0MC/p1677477374149359

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@yrs147 yrs147 requested a review from a team as a code owner February 27, 2023 07:39
@yrs147
Copy link
Contributor Author

yrs147 commented Feb 27, 2023

@Vad1mo

@MinerYang MinerYang added the release-note/ignore-for-release Do not include PR or Issue for release notes label Mar 6, 2023
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: yrs147 <yashraj14700728@gmail.com>
@chlins chlins merged commit 7ace561 into goharbor:main Apr 24, 2023
@OrlinVasilev
Copy link
Member

@yrs147 congratulations on merging your first PR :)) Welcome to the club :)))

@yrs147
Copy link
Contributor Author

yrs147 commented Apr 25, 2023

Thanks @OrlinVasilev , Looking forward to contribute more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants