Disable a prohibitively slow code branch when reparenting nodes #85517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 29, 2023
KoBeWi
approved these changes
Nov 29, 2023
|
Thanks! |
|
I assume this will be reverted once the fixes in #85502 gets finished up? |
|
Yes, or any other follow up that improves performance with introducing new bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses (but doesn't fix) #84910 by temporarily disabling enhancements added in #80721 and its two follow-ups (#83934, #83263).
This temporarily reopens #74155.
We still want this functionality, but some improvements to the approach are necessary. We discussed #85502 as well, but it only addresses the issue by ignoring a handful of potentially valid cases. So for the time being we have to disable the feature, until a better solution is available.