Renderer Viewport correct sizeof usage.
#84952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current usage. In viewport_find_from_screen_attachment - Allocates a list of pointers, eg sizeof(RID*) * ridcount. We need fill that buffer viewport_owner.fill_owned_buffer(rids); ... p_rid_buffer[idx] = _make_from_id((validator << 32) | i); _make_from_id returns an RID object, not a pointer. Since there isn't a copy constructor, a bitwise copy of the object occurs. This issue will only present itself under 32bit builds. sizeof(RID) : 8 sizeof(RID*) : 4 whereas 64bit builds they are both 8.
akien-mga
approved these changes
Nov 16, 2023
akien-mga
changed the title
sizeof usage.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current usage.
In viewport_find_from_screen_attachment
We need fill that buffer
viewport_owner.fill_owned_buffer(rids);
...
p_rid_buffer[idx] = _make_from_id((validator << 32) | i);
_make_from_id returns an RID object, not a pointer.
Since there isn't a copy constructor, a bitwise copy of the object occurs.
This issue will only present itself under 32bit builds.
sizeof(RID) : 8
sizeof(RID*) : 4
whereas 64bit builds they are both 8.