Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TreeItem truncating node names too much when using a custom icon #84001

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix TreeItem truncating node names too much when using a custom icon #84001

merged 1 commit into from
Oct 27, 2023

Conversation

chybby
Copy link
Contributor

@chybby chybby commented Oct 26, 2023

get_icon_size returns the size of the Texture2D whereas _get_cell_icon_size takes into account the max width.

Fixes #83801.

@chybby chybby requested a review from a team as a code owner October 26, 2023 13:36
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 26, 2023
YuriSizov
YuriSizov approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's the only place left that used this method instead of the wrapper.

@akien-mga akien-mga merged commit 924d861 into godotengine:master Oct 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Names of nodes with custom icon gets truncated too early
4 participants
@chybby @akien-mga @YuriSizov @AThousandShips