Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable "Edit Transitions..." item if no animations are present #83402

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Disable "Edit Transitions..." item if no animations are present #83402

merged 1 commit into from
Oct 16, 2023

Conversation

YeldhamDev
Copy link
Member

Nothing happens when clicked if the AnimationPlayer has no animations, which causes confusion, so it should be disabled with everything else too.

@YeldhamDev YeldhamDev added this to the 4.2 milestone Oct 15, 2023
@YeldhamDev YeldhamDev requested a review from a team October 15, 2023 15:31
@fire fire requested a review from a team October 15, 2023 20:19
SaracenOne
SaracenOne approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM!

@akien-mga akien-mga merged commit 7211c03 into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the edit_transitions_hide branch October 16, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@YeldhamDev @akien-mga @SaracenOne