Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Fix lookup for singleton instance types. #83249

Merged
merged 1 commit into from
Oct 13, 2023
Merged

C#: Fix lookup for singleton instance types. #83249

merged 1 commit into from
Oct 13, 2023

Conversation

zaevi
Copy link
Contributor

@zaevi zaevi commented Oct 13, 2023

Fixes #83237

Use {ProxyName}Instance to find correct types. (Like ResourceUidInstance instead of ResourceUIDInstance)

@zaevi zaevi requested a review from a team as a code owner October 13, 2023 08:50
@akien-mga akien-mga added this to the 4.2 milestone Oct 13, 2023
raulsntos
raulsntos approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you so much for fixing this!

@akien-mga akien-mga merged commit 68cc80e into godotengine:master Oct 13, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[C#] ResourceUid is broken.
3 participants
@zaevi @akien-mga @raulsntos