Disable update spinner when debug redraw is active

[KoBeWi]

#79169 (comment)

[clayjohn]

I don't understand why we would disable this. The point of debug redraw is to show when things are redrawn. Since the update spinner updates every frame, it makes sense that it constantly triggers the debug redraw code.

Is the concern about having something flashing on the screen?

To me it looks like it's working as intended.

[KoBeWi]

The problem is that update spinner triggers debug redraw, which causes the update spinner to redraw and it runs into an infinite redraw loop. Update spinner is supposed to indicate that something is being updated, but here it's signalling its own update, which is pointless. I think perfectly the update spinner should be an exception from debug redraw, but it's such a niche feature that anything more than a quickfix isn't probably worth it.

[clayjohn]

The problem is that update spinner triggers debug redraw, which causes the update spinner to redraw and it runs into an infinite redraw loop. Update spinner is supposed to indicate that something is being updated, but here it's signalling its own update, which is pointless. I think perfectly the update spinner should be an exception from debug redraw, but it's such a niche feature that anything more than a quickfix isn't probably worth it.

Ah, okay right. That makes sense.

[akien-mga]

Thanks!