Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript DocGen: Fix regression with return metatypes #83049

Merged
merged 1 commit into from
Oct 10, 2023
Merged

GDScript DocGen: Fix regression with return metatypes #83049

merged 1 commit into from
Oct 10, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Oct 9, 2023

function->return_type->get_datatype() and function->get_datatype() have different values:

godot/modules/gdscript/gdscript_analyzer.cpp

Line 1654 in 42425ba

p_function->set_datatype(type_from_metatype(resolve_datatype(p_function->return_type)));

Since DocGen previously did not take metatypes into account, this bug did not appear.

@dalexeev dalexeev added this to the 4.2 milestone Oct 9, 2023
@dalexeev dalexeev requested a review from a team as a code owner October 9, 2023 14:52
@akien-mga akien-mga merged commit 7f5be55 into godotengine:master Oct 10, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-docgen-fix-return-metatype-regression branch October 10, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@dalexeev @akien-mga