AnimationMixer: Fix non-numeric misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_CONTINUOUS
#83030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
patch-misc-blending
branch
from
8afe1d5
to
6804d6c
Compare
TokageItLab
changed the title
AnimationMixer: misc type (Resource, Dictionary etc.) values cannot be blended with UpdateMode.UPDATE_DISCRETE
TokageItLab
changed the title
AnimationMixer: misc type (Resource, Dictionary etc.) values cannot be blended with UpdateMode.UPDATE_DISCRETEAnimationMixer: misc type (Resource, Dictionary etc.) values cannot be blended with UpdateMode.UPDATE_DISCRETE
TokageItLab
changed the title
AnimationMixer: misc type (Resource, Dictionary etc.) values cannot be blended with UpdateMode.UPDATE_DISCRETEAnimationMixer: misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_DISCRETE
akien-mga
reviewed
Oct 9, 2023
TokageItLab
force-pushed
the
patch-misc-blending
branch
from
20ad0b3
to
c4743ba
Compare
TokageItLab
changed the title
AnimationMixer: misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_DISCRETEAnimationMixer: misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode. UPDATE_CONTINUOUS
TokageItLab
changed the title
AnimationMixer: misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode. UPDATE_CONTINUOUS AnimationMixer: misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode. UPDATE_CONTINUOUS
TokageItLab
changed the title
AnimationMixer: misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode. UPDATE_CONTINUOUSAnimationMixer: misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_CONTINUOUS
TokageItLab
changed the title
AnimationMixer: misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_CONTINUOUSAnimationMixer: non-numerical misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_CONTINUOUS
akien-mga
changed the title
AnimationMixer: non-numerical misc type (Resource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_CONTINUOUSResource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_CONTINUOUS
akien-mga
changed the title
Resource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_CONTINUOUSResource, Dictionary & etc.) values cannot be blended with UpdateMode.UPDATE_CONTINUOUS
akien-mga
approved these changes
Oct 9, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82949
Closes #82905
If you try to use
UpdateMode.UPDATE_CONTINUOUSwith a non-numeric Misc Type value, it will fail to apply the value because there is currently no way to blend usingUpdateMode.UPDATE_CONTINUOUS.I believe that in the future we should convert them to have weight as
Pair<Variant value, float weight>in the similar way thatboolvalues are converted to0or1and blended, but for now it will forceUpdateMode.UPDATE_DISCRETEinstead ofUpdateMode.UPDATE_CONTINUOUSsince it is useless now.