Fix NavigationObstacle3D debug being affected by rotation and scale #82593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NavigationObstacle3D debug being affected by rotation and scale.
akien-mga
approved these changes
Oct 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NavigationObstacle3D debug being affected by rotation and scale.
An avoidance obstacle has no full transform, it only has a position. The late change from Node to Node3D brought with it that all the Node3D properties are inherited so now the debug visuals can end up rotated or at the wrong size due to scale changes.
No property of obstacles or agents, e.g. radius, is affected by node transform except the position. While xforming radius and vertices now is debatable it would break compatiblity so fixing the debug is the better option for now.