Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch between surface vertex array generation inside the function and the caller. #82451

Merged

Conversation

DarioSamo
Copy link
Contributor

@DarioSamo DarioSamo commented Sep 27, 2023

Fixes a possible mismatch between the parameter that the vertex array is searched for in the mesh storage and the function that creates it. When falling in an edge case where the user enables TAA at runtime, this could cause an infinite amount of vertex arrays to be created. Fixes #82446.

This should be a fairly low risk change.

Bugsquad edit:

@DarioSamo
Copy link
Contributor Author

Seems to also fix #82791.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

This fixes a bad regression in 4.2 Dev 6, so it should be a prioritiy merge for the next release

@akien-mga akien-mga merged commit 829d9bb into godotengine:master Oct 5, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants