Rename close requests to delete requests in GraphEdit
#82370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
force-pushed
the
graphs-request-rename-close-delete-please
branch
from
a45c85d
to
378ab38
Compare
Geometror
approved these changes
Sep 30, 2023
|
Thanks! |
Zylann
added a commit
to Zylann/godot_voxel
that referenced
this pull request
Oct 29, 2023
Was changed back in godotengine/godot#82370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on godotengine/godot-proposals#5271 (comment) and discussions on RocketChat with @Zylann, @Mickeon and @KoBeWi.
Renames
GraphEdit'sclose_nodes_requestback todelete_nodes_request, and renamesGraphElement'sclose_requesttodelete_request, as well as some relevant internal methods. Note that the change toGraphEditunbreaks compatibility (since this was the name prior to 4.2), andGraphElementis a new node in 4.2. So this only breaks compat with previous dev snapshots.