[3.x] Fix cursor after last character INDEX in line counting as a character outside of the viewing area #81352
Conversation
…de of the viewing area The cursor column can be after the last_visible_char index and still be visible.
|
I would suggest to open a 4.x fix as well, we tend to prioritise getting fixes on the main development branch first |
|
I'm currently trying to fix it for 4.x and will make a draft soon (tonight). That code has been overhauled, so it's rather different. In the linked issue you can see that the bug is not exactly the same. Well, I'm on it |
|
Great! Sorry missed that detail as the relevant code seemed the same and had the same range check offset |
akien-mga
changed the title
|
Haha, thought the same! So I tried the same fix, but it just fixes one area and breaks another... |
|
@Paulb23, could you please have a look at this micro PR as well? |
|
Thanks! |
|
@akien-mga: can we cherrypick this for 3.5, please? 3.6 is months (a year?) away from being released (based on past 3.6 dev snapshot dates). |
akien-mga
added
the
cherrypick:3.5
|
Cherry-picked for 3.5.3. |
akien-mga
removed
the
cherrypick:3.5
Fixes #81349 for Godot 3.x
This fix should be ok like this, because last character and cursor are rendered together (at least on my machine: Ubuntu)
Before fix
before.webm
After fix
after.webm