Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SpinBox not clearing text on improper input #81094

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fix SpinBox not clearing text on improper input #81094

merged 1 commit into from
Sep 11, 2023

Conversation

OXTyler
Copy link
Contributor

@OXTyler OXTyler commented Aug 28, 2023 •
edited by KoBeWi
Loading

fixes #81071
The issue was when parsing errors are thrown, it does not revert back to original text

@OXTyler OXTyler requested a review from a team as a code owner August 28, 2023 20:42
@AThousandShips AThousandShips added this to the 4.2 milestone Aug 28, 2023
@AcatXIo
Copy link
Contributor

AcatXIo commented Aug 28, 2023

Thanks for providing the fix!

@akien-mga akien-mga changed the title Fixes SpinBox not clearing text on improper input Fix SpinBox not clearing text on improper input Sep 11, 2023
@akien-mga akien-mga merged commit ca2d5b2 into godotengine:master Sep 11, 2023
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

SpinBox does not clear text on Enter key if the text is "Nil".
5 participants
@OXTyler @AcatXIo @akien-mga @KoBeWi @AThousandShips