Move default theme files to scene/theme
#81065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also puts the default theme icons into their own folder.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with theme internals, I figured that this organization of files makes more sense.
scene/resourcesis a place for type definitions, but default theme creates actual resources for the runtime. We didn't use to havescene/themebefore, so that placement is understandable. But now we do, so I think it's time to move.This change also puts default theme icons into their own subfolder, similar to how the editor theme and icons are organized. This makes it a bit easier to navigate the project, since code files are no longer hidden in the folder with dozens of icons. I updated all the relevant references and comments, and removed a couple of includes which I don't see the need for. I added a missing codeowners link for the
scene/themefolder as well.