Fix 2D/3D viewport context switching issues when script editor is floating #80647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when Script editor floating
akien-mga
changed the title
|
This is a duplicate of #80307 which has the exact same changes. I slightly prefer the names chosen here so let's merge this one. |
akien-mga
added
topic:gui
cherrypick:4.1
akien-mga
changed the title
akien-mga
approved these changes
Aug 17, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Thank you all guys, I'm looking forward to contribute more, I'll be always happy to help the community ! |
jsjtxietian
deleted the
CollisionShape3D-Shape-Size-handles-missing-when-Script-editor-floating
branch
|
Cherry-picked for 4.1.3. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr solves issue #80588.
I added a simple function to tell whether the script editor is floating or not, and when script editor is floating, skip_main_plugin should be false so the plugin will draw itself's gizmos.
Bugsquad edit: