Fix menu items that trigger secondary interface missing ellipsis

[jcovin293]

This PR fixes #80347 where menu items that trigger a secondary interface (such as a dialog) do not have an ellipsis on their menu items.

[akien-mga]

Could you amend the commit message to be more explicit? The PR title is good, the commit should use the same title (and can include "Fixes #80347" in the body of the commit message, not in the title).

[jcovin293]

I have amended the commit with the requested changes. Let me know if there are any other things that need to be added.

[YuriSizov]

Looks good to me, but needs a rebase.

[jcovin293]

I'm new to git. How would I rebase because there seems to be a merge conflict in scene_tree_dock.cpp?

[YuriSizov]

That's exactly why you need to do a rebase right now, to resolve those conflicts. When you do a rebase, if there are conflicts that cannot be resolved automatically, you'll be prompted about it and the rebase is going to be put on hold. This allows you to modify the files and decide how to resolve conflicts and then proceed.

What do you use to make the changes and to work with git?

[jcovin293]

I use Visual Studio Code. I have tried resolving the conflict via the UI but it doesn't seem to be working as expected as it requires me to make another commit which might not look good on the git history.

[YuriSizov]

@jcovin293 While I'm not sure how it would create a new commit, you can fix that after the fact by doing an interactive rebase and squashing your commits together with the fixup option.

[AThousandShips]

You accidentally closed your PR by resetting the branch, if you push to the branch again we can reopen, alternatively you can open a new PR with a single commit containing the changes

[jcovin293]

I have pushed a new commit. Do I need to do something to reopen it or is it on your end?

[YuriSizov]

All is in order now, good job!

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉