[Linux/Freedesktop] Implement native file selection dialog support. #80104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
force-pushed
the
freedesktop_native_file_dialog
branch
from
6c726c3
to
27606cc
Compare
timothyqiu
reviewed
Aug 1, 2023
bruvzg
force-pushed
the
freedesktop_native_file_dialog
branch
from
27606cc
to
6fbd1f9
Compare
timothyqiu
reviewed
Aug 1, 2023
bruvzg
force-pushed
the
freedesktop_native_file_dialog
branch
from
6fbd1f9
to
0902727
Compare
bruvzg
commented
Aug 1, 2023
| window_id = MAIN_WINDOW_ID; | ||
| } | ||
|
|
||
| String xid = vformat("x11:%x", (uint64_t)windows[window_id].x11_window); |
There was a problem hiding this comment.
Note: the file dialog part should not depend on X11.
The only change that should be necessary for the Wayland DisplayServer is xid value. Wayland xid should be "wayland:HANDLE", where HANDLE is a surface handle obtained via xdg-foreign protocol.
There was a problem hiding this comment.
Wayland xid should be "wayland:HANDLE", where HANDLE is a surface handle obtained via xdg-foreign protocol.
Great, thanks for letting me know! I really appreciate that you're making the portal implementation generic.
timothyqiu
reviewed
Aug 1, 2023
bruvzg
force-pushed
the
freedesktop_native_file_dialog
branch
from
0902727
to
192b5f5
Compare
akien-mga
reviewed
Aug 4, 2023
bruvzg
force-pushed
the
freedesktop_native_file_dialog
branch
from
192b5f5
to
6cc314e
Compare
akien-mga
approved these changes
Aug 17, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #79574 and #47499 for Linux. Should allow accessing files outside flatpak sandbox (should auto map files to
/run/user/$UID/doc/).