Fix some mixups between 2D/3D in documentation #79781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
commented
Jul 22, 2023
AThousandShips
commented
Jul 22, 2023
| @@ -230,8 +230,8 @@ | |||
| - [code]type[/code]: Always [constant NavigationPathQueryResult3D.PATH_SEGMENT_TYPE_LINK]. | |||
| - [code]rid[/code]: The [RID] of the link. | |||
| - [code]owner[/code]: The object which manages the link (usually [NavigationLink3D]). | |||
| - [code]link_entry_position[/code]: If [code]owner[/code] is available and the owner is a [NavigationLink2D], it will contain the global position of the link's point the agent is entering. | |||
| - [code]link_exit_position[/code]: If [code]owner[/code] is available and the owner is a [NavigationLink2D], it will contain the global position of the link's point which the agent is exiting. | |||
| - [code]link_entry_position[/code]: If [code]owner[/code] is available and the owner is a [NavigationLink3D], it will contain the global position of the link's point the agent is entering. | |||
There was a problem hiding this comment.
Confirmed from the code
AThousandShips
force-pushed
the
doc_dim_fix
branch
from
0a5483e
to
7512d88
Compare
kleonc
approved these changes
Jul 23, 2023
|
Thanks! |
|
At least some of these changes needs to be cherry picked for 4.1 |
|
It does seem to be trivial to cherry pick for 4.1, tagged, remove if it isn't correct. |
AThousandShips
added
the
cherrypick:4.1
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if there are other cases but seems to mostly have caught all
If the changes are considered too minor compared to the impact on translation I can limit it to only cover the incorrect links, which I think should be fixed at minimum as they will throw people off