Add support for indexed properties in GDExtension #79763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Jul 25, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to godotengine/godot-cpp#1182.
Required for godotengine/godot-cpp#1186.
This adds support for binding indexed properties (
ADD_PROPERTYI) from GDExtension, which at the moment is not possible due to there being no index parameter in theclassdb_register_extension_class_propertyfunction.This PR resolves this in a backwards-compatible way by adding a new function called
classdb_register_extension_class_property_indexedthat effectively replaces the old function. The implementation for the old function now calls the new function, and simply provides the default value of -1 for the index.