Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve headings for the export mode in the Export dialog #79725

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Improve headings for the export mode in the Export dialog #79725

merged 1 commit into from
Oct 30, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 20, 2023 •
edited
Loading

"Export as dedicated server" now uses a less confusing heading.

image

Previously, this would have said "Resources to export", which is misleading if you refer to the checkboxes alone.

@Calinou
Improve headings for the export mode in the Export dialog
73c1b21 
"Export as dedicated server" now uses a less confusing heading.
@Calinou Calinou added enhancement topic:editor cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 20, 2023
@Calinou Calinou added this to the 4.2 milestone Jul 20, 2023
@AThousandShips
Copy link
Member

Should close #79684

YuriSizov
YuriSizov approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit ca6b404 into godotengine:master Oct 30, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-export-mode-clarify-heading branch October 31, 2023 07:34
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:export usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Exporting specific resources is broken, includes resources it should not include
4 participants
@Calinou @AThousandShips @akien-mga @YuriSizov