Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3.x compatibility for animation loop mode #79155

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add 3.x compatibility for animation loop mode #79155

merged 1 commit into from
Jul 10, 2023

Conversation

Owl-A
Copy link
Contributor

@Owl-A Owl-A commented Jul 7, 2023 •
edited by AThousandShips
Loading

Bugfix for #57779 Conversion from 3.x to 4.x stops looping animations.

@akien-mga akien-mga changed the title add 3.x compatibility for animation loop mode Add 3.x compatibility for animation loop mode Jul 7, 2023
@AThousandShips AThousandShips requested a review from a team July 7, 2023 12:22
@AThousandShips AThousandShips added this to the 4.2 milestone Jul 7, 2023
AThousandShips
AThousandShips approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't tested myself so TIWAGOS

@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 7, 2023
akien-mga
akien-mga approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me too.

@akien-mga akien-mga merged commit dbec337 into godotengine:master Jul 10, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

@Owl-A Owl-A deleted the bugfix-57779 branch July 14, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:animation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Converting scene from 3.x to 4 causes animations to stop looping
4 participants
@Owl-A @akien-mga @YuriSizov @AThousandShips