Collapse bottom panel if there is no active tab #79078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
added
bug
topic:editor
cherrypick:4.1
KoBeWi
force-pushed
the
if_you_gaze_into_the_empty_bottom_panel,_the_empty_bottom_panel_gazes_also_into_you
branch
from
829ff36
to
59ae7e2
Compare
YuriSizov
reviewed
Jul 10, 2023
Comment on lines
+5296
to
+5297
| bottom_panel_items[0].control->show(); // _bottom_panel_switch() can collapse only visible tabs. | ||
| _bottom_panel_switch(false, 0); |
There was a problem hiding this comment.
Something that we should probably implement properly in the future.
YuriSizov
approved these changes
Jul 10, 2023
|
Thanks! |
KoBeWi
deleted the
if_you_gaze_into_the_empty_bottom_panel,_the_empty_bottom_panel_gazes_also_into_you
branch
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79022