Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BoxOccluder SVG #77421

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix BoxOccluder SVG #77421

merged 1 commit into from
May 24, 2023

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented May 24, 2023

image

Hmm, this seems a bit messed up, what's with the dark outline?

image

Ah, look what's hiding here!

image

Removes the hidden box, also simplifies the path by drawing the arc at once with the large-arc-flag. (total saved 0.4 kB)

@MewPurPur MewPurPur requested a review from a team as a code owner May 24, 2023 04:13
@akien-mga
Copy link
Member

Undercover Unity logo smuggled in by @lawnjelly? 📦 :p

@akien-mga akien-mga added this to the 4.1 milestone May 24, 2023
@lawnjelly
Copy link
Member

Undercover Unity logo smuggled in by @lawnjelly? :p

Not me!! 😁 I didn't create any of the svgs, this is @Calinou I believe.

@akien-mga
Copy link
Member

Technically, the front shape was occluding a box, so the icon was correct :P

@akien-mga akien-mga merged commit 7bdc458 into godotengine:master May 24, 2023
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the OwO-wats-dis branch May 24, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants