Enhance NodePath property editing

[KoBeWi]

• Change Clear button to a menu
• Add "Copy as Text" option, to copy the NodePath as text (accepts invalid paths too, so you can reference singletons or nodes from other scenes etc.)
• Add "Edit" option, to edit the NodePath manually
• Add "Show Node in Tree", which selects the target node (if available)

Code_k9ydA6CGlm.mp4

Closes #25289

[Iniquitatis]

Just curious: Why not take a reference/pointer to the popup and then popup->add_item(x)? I'm seeing such pattern (repeating getters or whatever on multiple lines) quite often in Godot's code base.

[KoBeWi]

idk, I just haven't thought about that. It's not like it's done consistently.

[MewPurPur]

I assume most people mainly need editing and clearing, so I'm wondering if we can spare the extra click so clearing a bunch of node paths doesn't take 4 times as long...

• Edit could be replaced by a line edit in the node selection menu.
• Copy as Text can be copied from that line edit, and we also have the "Copy Value" functionality on properties anyway.
• Can't think of anything different for View in Tree, so maybe it could be a second button

[ajreckof]

• Change Clear button to a menu

I'm not too sure about this but would it be possible to add them it to the menu that pops on right click and has "copy/paste value" instead of creating a new menu.

• Add "Copy as Text" option, to copy the NodePath as text (accepts invalid paths too, so you can reference singletons or nodes from other scenes etc.)

It feels like "copy / paste Value" should work like that instead of creating another functionality for it

• Add "Edit" option, to edit the NodePath manually

I think this should replace the clear button. But maybe this is just me as i mostly never use it and use the revert to default button.

[akien-mga]

Needs rebase. Then maybe @Calinou can review?

[KoBeWi]

Rebased. I ended up doing some refactoring, but I kept the behavior for now.
I considered replacing the menu button with right-click context menu, but a button is better for discoverability.

[Calinou]

I considered replacing the menu button with right-click context menu, but a button is better for discoverability.

I'd suggest supporting both if possible 🙂

[Calinou]

Tested locally (rebased on top of master f5696c3), it works as expected. Code looks good to me too.

A small UX issue I noticed is that when you use Show node in Tree, the focus will appear on the node in question (with the outline), but the old node remains selected:

I wonder if it should switch to the new node in the inspector automatically (and remove the selection on the current node instead). Still, this isn't blocking and can be refined in a future PR (like warning users if they enter a node path that isn't known to exist at compile-time).

[KoBeWi]

I could experiment with selecting single node, but either it would switch the inspector (so the node you were editing right now would disappear) or, if it's possible to preserve edited node, the inspector would show old node with another one selected in scene tree. Maybe the latter is fine, same happens when you are dragging a node.

[akien-mga]

Thanks!