Avoid sorting CallableCustomMethodPointers by their actual address values #72346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 30, 2023
|
Switched to a cleaner fix that just uses Because of how byte ordering works on little-endian machines, this will cause pointer digits to be compared from right to left, so they will no longer be sorted in a meaningful order. |
myaaaaaaaaa
changed the title
RandomShaper
requested changes
Jun 20, 2023
RandomShaper
approved these changes
Jun 20, 2023
It failed CI, so I had no choice 🙃 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#69874 is caused by signals being stored inside a
VMap<Callable, ...>. This means thatCallables that are allocated later would have a larger address and end up being sorted to the end of theVMap, making them easier to push/pop... until the C runtime starts recycling addresses, and connecting/disconnecting lots of signals becomes inexplicably slow.This patch "fixes" that problem in that it makes connecting/disconnecting consistently slow, so that signal performance problems become easier to diagnose.