Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor dock layout not saving correctly #62919

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

MinusKube
Copy link
Contributor

Fixes #57142

When saving the editor dock layout, the dock_[...] keys were never erased when names was empty, causing the config to keep the old values for these keys.

For example, if you had:

dock_1="Node"
dock_2="Inspector"

And you moved Node to dock_2, this was the result:

dock_1="Node"
dock_2="Inspector,Node"

It now makes sure the key is erased if names is empty (it also erases it even if it's non-empty, so the keys are always ordered correctly in the config).

This issue was caused by a regression from #48466

@akien-mga akien-mga merged commit 41dda3b into godotengine:master Jul 13, 2022
@akien-mga
Copy link
Member

Thanks!

@MinusKube MinusKube deleted the dock-layout-save-bug branch January 22, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.0] Editor don't save docks position
3 participants