Fix parser stuck in an error loop #62900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (4.0) #53345
Using the repro from this comment #53345 (comment) because I couldn't reproduce it with the code in the initial comment.
When lambda functions were added to GDScript, the behavior of
parse_precedence
had to be changed to not consume a token if a valid prefix rule didn't exist.godot/modules/gdscript/gdscript_parser.cpp
Line 2140 in d26442e
However, this can cause the parser to be stuck in an infinite loop in certain cases, since it never consumes the token causing the error.
With the assumption that this only happens with expression statements, I added an
advance()
call there, which will be called alongside the parser error.Bugsquad edit: This closes #53345.