Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too thin underline in brace match #62884

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 10, 2022

Fixes #60001

@KoBeWi KoBeWi added this to the 4.0 milestone Jul 10, 2022
@KoBeWi KoBeWi requested a review from a team as a code owner July 10, 2022 16:16
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be also multiplied by editor scale:

MAX(font->get_underline_thickness(font_size) * get_theme_default_base_scale(), 1));

@bruvzg
Copy link
Member

bruvzg commented Jul 10, 2022

If underline thickness can be less than one, the same changes should be added to the RTL and LinkButton as well, since they might have the same issue.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 10, 2022

The problem seems to occur only in TextEdit, at least with the default theme.

@akien-mga akien-mga merged commit f778660 into godotengine:master Jul 13, 2022
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the THICKUNDERLINE branch July 13, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brace matching does not work
3 participants