Add ok_button_text to AcceptDialog and cancel_button_text to ConfirmationDialog

[fire-forge]

Closes godotengine/godot-proposals#2419

Adds an ok_button_text property to AcceptDialog and cancel_button_text property to ConfirmationDialog. The main advantage of having these properties is to allow setting the OK and Cancel buttons' text from the inspector without requiring the use of a script.

Also documents AcceptDialog.dialog_close_on_escape since it was the only undocumented part of AcceptDialog.

[akien-mga]

Looks good to me.

[KoBeWi]

It seems to have problem similar to #39258

The properties will get translated, but unlike that issue the translated property doesn't seem get serialized 🤔

[bruvzg]

The properties will get translated, but unlike that issue the translated property doesn't seem get serialized 🤔

It's probably should store untranslated text as a public property and translated copy for the internal use like Label and Button do (since it is setting Button text, it's probably should avoid translating anything at all, button will do the rest automatically).

godot/scene/gui/button.cpp

Lines 82 to 83 in ca18a02

	case NOTIFICATION_TRANSLATION_CHANGED: {
	xl_text = atr(text);

godot/scene/gui/button.cpp

Lines 383 to 386 in ca18a02

	void Button::set_text(const String &p_text) {
	if (text != p_text) {
	text = p_text;
	xl_text = atr(text);

[fire-forge]

It's probably should store untranslated text as a public property and translated copy for the internal use like Label and Button do (since it is setting Button text, it's probably should avoid translating anything at all, button will do the rest automatically).

I've updated the PR to store untranslated text. Button seems to handle translation automatically.

[akien-mga]

Thanks!

[KoBeWi]

I didn't notice it then, but the FileDialog does translate the text and stores it in the scene :/

It would be great if this text wasn't stored at all; it depends on file mode anyway. Might require some clever usage of _validate_property().